[CI][L0] Modify files to enable installing L0 from .sh file #20411
+156
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
force-pushed
the
scripts-change
branch
from
14d1f57 to
ea190b7
Compare
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
force-pushed
the
scripts-change
branch
from
ea190b7 to
66b3302
Compare
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
force-pushed
the
scripts-change
branch
from
66b3302 to
38bd413
Compare
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
changed the title
luszczewskakasia1
changed the title
mateuszpn
requested changes
Oct 22, 2025
| string(REGEX MATCH "^[0-9a-fA-F]+$" IS_HEX "${UR_LEVEL_ZERO_LOADER_TAG}") | ||
|
|
||
| if(PkgConfig_FOUND AND NOT (TAG_LENGTH EQUAL 40 AND IS_HEX)) | ||
| pkg_check_modules(level-zero level-zero>1.24.3) |
There was a problem hiding this comment.
Probably >=, as it was above
| # just try to search for the path. | ||
| if(PkgConfig_FOUND) | ||
| pkg_check_modules(level-zero level-zero>=1.24.3) | ||
| string(LENGTH "${UR_LEVEL_ZERO_LOADER_TAG}" TAG_LENGTH) |
There was a problem hiding this comment.
Why UR_LEVEL_ZERO_LOADER_TAG is checked, and not set here?
There was a problem hiding this comment.
afaik this line of code checks the length of a given string and this length is checked in if-statement one line below. I think this is expected behaviour
There was a problem hiding this comment.
The behavior of further if conditions may be bad because if the variable is not set, its LENGTH is 0
luszczewskakasia1
force-pushed
the
scripts-change
branch
from
38bd413 to
87fa832
Compare
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
luszczewskakasia1
force-pushed
the
scripts-change
branch
3 times, most recently
from
bcf6515 to
0f571ed
Compare
luszczewskakasia1
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
luszczewskakasia1
force-pushed
the
scripts-change
branch
from
14636e7 to
70ee958
Compare
luszczewskakasia1
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mateuszpn
approved these changes
Oct 24, 2025
|
|
||
| set(UR_LEVEL_ZERO_LOADER_REPO "https://github.com/oneapi-src/level-zero.git") | ||
| # Remember to update the pkg_check_modules minimum version above when updating the | ||
| # clone tag |
There was a problem hiding this comment.
nit: Make the whole comment coherent, as you mention some "minimum version above" (if fact it is below now), and in l. 20 you mention the change again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change allows to use a L0 commit instead of a tag which in some cases is needed by developers.